Design comparison
Solution retrospective
Building most of the challenges is kinda hard to me because of my screen size. I'm using a 1280x720 screen, and since the challenges are "meant" to be for 375px and 1440px width, I kind of struggle... Still, it's fun to try it out!
Community feedback
- @corjonPosted about 2 years ago
For your concern about your screen size: You can right-click on your site and choose 'inspect'. This opens your browsers dev tools and at the top select 'responsive' then change the width to whatever you want. Hope this helps!
Marked as helpful0@ZephyroCodePosted about 2 years agoIt does! That's something I didn't think about before! Thanks! :D
0 - @AdrianoEscarabotePosted about 2 years ago
Hi Wilver Salazar, how are you?
I really liked the result of your project, but I have some tips that I think you will enjoy:
I noticed that you used a div with a
footer
class that div could be replaced by afooter
tag, it would improve the code structure! or wrap all content with the existingfooter
tag, as it is bad practice to have a page with more than one footer tag!- You have used <br> , using <br> is not only bad practice, it is problematic for people who navigate with the aid of screen reading technology. Screen readers may announce the presence of the element. This can be a confusing and frustrating experience for the person using the screen reader. You can read more in MDN.
The rest is great!
I hope it helps... 👍
Marked as helpful0@ZephyroCodePosted about 2 years agoHiya! It sure helps a lot, so I appreciate it a lot :D
About the footer... Well, that div with the footer class was meant to be used as the footer tag... however, I found myself in kind of a problem with the social media icons, so I ended up using that container as footer... Maybe it would be better to set those icons as a div and the footer as an actual footer...
Also the br, well, that's a huge help, I didn't know about that problem, so I'll note that and get rid of br once and for all!
Thanks a lot for the feedback! :D
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord