Design comparison
Solution retrospective
Can someone give me some tips on how I could improve my SCSS/SASS?
Community feedback
- @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
Remove the
Article
element inside theHeader
, it is unnecessary. -
Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The
Anchor Tag
will achieve this. -
Your "buttons" need to have a
cursor: pointer
,hove
, andfocus-visible
. -
The “Illustrations” serve no other purpose than to** be decorative**; They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hides it from assistive technology. -
The "Ready To Build Your Community?" should be an
H3
heading. -
The "bottom-links" need to wrapped in a
nav
element and each one should ne wrapped in anAnchor Tag
.
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
Marked as helpful1@allfigueiredodevPosted almost 2 years ago@vcarames
Thank you! Helped a lot!
Already did the changes.
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord