Design comparison
Solution retrospective
Please i need feedback, still got issues with responsiveness
Community feedback
- @adarshcodesPosted almost 4 years ago
Hi @EmunahNgwa, You did good work here.
- But I saw you use background image both on the body and the .page class as well. remove from one. and add
background-size: cover;
to it. - And also just give width in px to the image, 650 px is looking fine to me. You added height 100% so it makes it stretched. I hope it would help you. Keep it up. Happy Coding😀
1 - But I saw you use background image both on the body and the .page class as well. remove from one. and add
- @RenszCamachoPosted almost 4 years ago
Hello. EmunahNgwa.
Just I few suggestions in my humble newbie opinion. 😊
In your footer, you're using 'font-awesome', I would do something like this.
<footer><a href="#"><i class="fa fa-facebook"></i></a></footer>
So this way you have content inside your anchors.
- Another thing is background placement. It looks weird. So I would do it like so:
Remove the backgrounds from your body tag and place it into the page classes
.page { padding: 8%; background: transparent; display: grid; grid-row: 1fr; min-height: 100vh; color: rgba(255, 255, 255); background-image: url("images/bg-mobile.svg"); background-repeat: no-repeat; background-size: cover; background-color: hsl(257, 40%, 49%); }
Hopefully, it helps.
Happy coding🧑💻
2@EmunahNgwaPosted almost 4 years ago@RenszCamacho Hi Rens, Thanks for your humble opinions i really appreciate it when I try to give a colour to my .page class, it does not show up i dont know why, so i just gave it to the body directly. maybe u can have a way for which that works ...
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord