Design comparison
Solution retrospective
I have just completed my 4th day project 'huddle landing page'. Kindly go through and give me feedback.
Community feedback
- @ApplePieGiraffePosted almost 4 years ago
Hi, Guliye! 👋
Good job on this challenge! 👏
I suggest,
- Adding a maximum width to the main container or wrapper to prevent the content of the page from becoming too stretched on extra-large screens.
- Horizontally centering the hero image in the mobile layout of the site.
- Adding
min-height: 100vh
to thebody
to ensure that it is always as large as the viewport and the background image fills the entire area of the screen.
Keep coding (and happy coding, too)! 😁
1@guliye91Posted almost 4 years ago@ApplePieGiraffe thanks. i appreciate. i will integrate them. happy cooding too
0 - @janegcaPosted almost 4 years ago
Hi Guliye, for responsive design check out Kevin Powell's channel on YouTube and his Conquering Responsive Layouts course. Or start with Free Code Camp's Responsive Web Design
BEM (Block-Element-Modifier) is a methodology for naming classes in CSS, for more info checkout this BEM Naming Cheat Sheet
Hope that's of some help. Happy coding.
1 - @janegcaPosted almost 4 years ago
HI Gullye, your design is nicely responsive. Two small nits, the text on the button doesn't match the design; the hover effect is missing on the social icons (checkout CSS-Tricks: Change Color of SVG on Hover
Nice job overall. Happy coding.
1@guliye91Posted almost 4 years ago@janegca Thank you for the feedback bro. I appreciate. bro i want to improve my responsive design and become expert on it. please give me resources that i can use to enhance it.
the other thing, what is BEM
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord