@MahmoodHashem
Posted
Great work on the website design! The overall look and feel is really impressive. However, there are some issues with the challenge:
- I noticed that the website has a horizontal scrollbar, which can negatively impact the user experience. To improve this, adjust the size of subscribe section in the footer
- There are lots of useless css implementation that you should eliminate, I think you need to practice More Css flexbox which I really recommend This guide to Learn and these Games Froggy and Zombies to practice.
- The curve section is very simple, just put every section in the
sectiontag and set the background color of that section to the curved image's color and then put top curved to the top of the section and bottom curved to the bottom of the section- Example
<section class="user-wrapper">
<div class="top-curved-bg">
<!-- your top curve -->
<img src="./top-curved-bg-address" alt="top" class="top">
</div>
<div class="content-section">
Your contents
</div>
<div class="bottom-curved-bg">
<!-- your bottom curve -->
<img src="./images/bg-section-bottom-desktop-2.svg" alt="bottom" class="bottom">
</div>
</section>
Additionally, it would be beneficial to organize your project files in a more structured manner. I recommend separating the assets (such as images, icons, and fonts) into a dedicated "assets" directory(for this challenge just create an image folder and put all the images into it), while keeping the main files (Readme, index, style, and script) in the root folder. This will help keep your codebase more organized and easier to navigate.
Overall, Your dedication is commendable, and making these small adjustments can further improve the user experience. Keep up the excellent work!
Marked as helpful
