Design comparison
Solution retrospective
Following the challenge, I tried to do the best I could within what I know and with a little research, but I believe I can improve in the future. Can you give me tips on how to improve the code in general?
I used CSS Grid and Flexbox to make the page organized and responsive, but I'm not sure if I used them in the best way. Do you have any tips, what do you think?
Community feedback
- @correlucasPosted about 2 years ago
👾Oi Leo Silva, tudo bem? Parabéns pelo desafio!
Essa sua solução tá bem completa eu nem tenho nada pra adicionar, vou deixar só uma dica pra poupar seu tempo em novos projetos. O CSS padrão vem com um monte de comportamentos que deixam o código dificil de configurar, por exemplo, margens, imagens, animações e etc. Usando esse CSS RESET, você vai salvar um bom tempo usar esse arquivo que já reseta a maioria das coisas como margens, imagens, animações e etc. Vai salvar um bom tempo usar isso desde o começo: https://piccalil.li/blog/a-modern-css-reset/
👋 Espero que essas dicas tenham sido úteis e continue codando!
Marked as helpful1@leozizzPosted about 2 years agoFala @correlucas! Tudo certo?
Muito obrigado pelo feedback e pelas dicas do CSS Reset! Já venho aplicando algo semelhante em projetos mais recentes e com certeza o CSS RESET que você mandou vai ser de grande ajuda!
Muito obrigado novamente pelas dicas Lucas! Sucesso!
1@correlucasPosted about 2 years ago@leozizz Pra cima irmão! Hoje postei um novo desafio e se vc quiser olhar e deixar alguma dica, tmj, tbm sou iniciante
0 - @superschoolerPosted over 2 years ago
Hey Leo, awesome job on the project and great use of CSS Grid. Using Grid can help you save a lot of unnecessary <div>s in the code over flexbox, and I see you used it wonderfully.
Because you did so well, I only have one small criticism. I'd probably add:
.illustration { align-self: center; }
This will keep the picture centered vertically next to the text when your media query hits so it's not way up next to the logo on iPad-sized screens. I'd probably also change the media query to at least 700px since the image is so small between 577px and 700px/
Marked as helpful1@leozizzPosted over 2 years ago@superschooler Thank you so much for the feedback and the tip!
I tested what you suggested and it really got better, in addition I added a specific media querie for 700px screens and made some adjustments so that the page behaves better for different screen sizes.
Thank you one more time! ;)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord