Design comparison
SolutionDesign
Solution retrospective
My first frontend project mentor any feedback is appreciated
Community feedback
- @al3xbackPosted almost 3 years ago
Hi Emiliano,
For this case, it would be good if we use fixed value instead of percentage for max-width on container class. If we look on larger desktop or simply zoom out then we will see the difference.
I would change to this:
.container { max-width: 1200px; padding: 3% 5%; margin: 0 auto; }
Marked as helpful0@RokuFSDPosted almost 3 years ago@al3xback I made the change and it really looks much better thanks for the warning, I also realized that I had not loaded the images correctly when uploading them to github I will review other projects to see if that error occurs thanks!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord