Design comparison
SolutionDesign
Solution retrospective
Good challenge. I did button hover background and icon hover colors different for my taste.
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! 👋 Here is some feedback to further improve your code:
- Logo
alt tag
should ONLY⚠️ state the company’s name.
- The “illustration” in this component are purely decorative. ⚠️ Their
alt tag
should be left blank to hide them from assistive technology.
More Info:📚
https://www.w3.org/WAI/tutorials/images/
- The social media icons are meant to be interactive ⚠️. So each individual icon needs to be wrapped in a
anchor
element and have anaria-label
for accessibility.
More Info:📚
- Your "buttons" were created with the incorrect element ❌. When the user clicks on the button they should be directed to a different part of you site. The
anchor tag
will achieve this.
More Info:📚
- There is no need to have separate stylesheets ❌, as it can affect site performance. Instead have one single stylesheet ✅.
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! 👾
Marked as helpful0@aykutminikliPosted almost 2 years ago@vcarames thank you for taking your time and giving advice. I will read the links and correct the code in later time and will try to make later projects more carefully. I checked your code too nice animation touches.
1 - Logo
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord