Design comparison
Solution retrospective
If you have ANY observation please let me know! Thanks!
Community feedback
- @ApplePieGiraffePosted almost 4 years ago
Hey, Cesar Pintos! 👋
Good work on this challenge! 👏
As cguttweb mentioned, I think you should do a little more work on the responsiveness of the site so that it looks good on desktop and mobile screens and everything in between. Also, I suggest adding
background-size: cover
to the background image in both the desktop and mobile layouts andbackground-repeat: no-repeat
to the background image in the desktop layout to ensure that the background looks good at all screen sizes. 😉Keep coding (and happy coding, too)! 😁
1@argie2099Posted almost 4 years ago@ApplePieGiraffe thank you so much for this observations! I will make SURE I'll fully integrate this into my next projects. Happy coding to you!
0 - @cguttwebPosted almost 4 years ago
Hey,
It looks great. I have a couple of suggestions make sure to add alt text to your images that will fix your accessibility issues and perhaps look at adjusting your media queries as it looks good on mobile and desktop but on tablet it overflows the screen.
1@argie2099Posted almost 4 years ago@cguttweb Yes I knew about the tablet issue but that was not asked for this challenge so I simply didn't add it lol. Thanks for your feedback! Will definitely add alt text to my images and SVGs
0@cguttwebPosted almost 4 years ago@argie2099 Fair enough it's better than my initial attempt :)
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord