Submitted almost 3 years ago
Huddle Landing Page Single Introductory Section | HTML CSS FLEXBOX
@obaryo
Design comparison
SolutionDesign
Solution retrospective
Feedback will be much appreciated.
Community feedback
- @osoriodevPosted almost 3 years ago
Hello Obuhri.
Your solution looks great. As a suggestion you can use
a
tags for the social media icons, I think it is more appropriate than using aspan
. I hope this helps ✌1@obaryoPosted almost 3 years ago@osoriodev that was actually what I did at first but I got an accessibility issue so I changed it to span. Thanks though.
0@osoriodevPosted almost 3 years ago@obaryo Maybe you forgot the aria-label attribute, this must be used when there is no discernible text.
<a href="#" aria-label="Facebook"> <i class="facebook-icon"></i> </a>
Marked as helpful0@obaryoPosted almost 3 years ago@osoriodev oh nice. I will try that. **edit: it worked, learned something new today, thanks a lot.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord