Design comparison
Solution retrospective
I would like to get some feedback as this is my first challenge to do. Thank you.
Community feedback
- @grace-snowPosted almost 4 years ago
Hi
This looks really nice on mobile, well done!
I'd lose the div wrapping the button and place classes on the button itself instead (really, that element would probably be a link to a registration page rather than a button, but that's not that important to change)
I would definitely add links to your social icons though ☺
Good job on this
0@Gehad75Posted almost 4 years ago@grace-snow Thank you a lottt <3. I will change this :)
1 - @MasterDev333Posted almost 4 years ago
Great work @Gehad. It would be better if you add some transitions to your buttons. transition: all .3s ease-in-out; Add more media queries to make it fully responsive, especially under 1200px. Hope it helps. Happy coding~ :)
0@Gehad75Posted almost 4 years ago@MasterDev333 Thank you a lot for your notes, I work on doing this <3.
0 - @axevldkPosted almost 4 years ago
Hi, @Gehad Salem Fekry ~ I have studied your work, and good work on your first challenge. Here are some of my opinions on your work.
-
Font sizes don't match with design. I think you can revise them easily.
-
Hope you to add padding to container, so that it won't fit whole screen under small resolution.
-
You can set width of image as 50% or so, so that it won't take too much space compared to content.
Hope my words can help you even a bit. Happy coding ~ ✨
0@Gehad75Posted almost 4 years ago@axevldk Thank you a lot for your notes, I will update the code. <3
1@Gehad75Posted almost 4 years ago@axevldk I have made the changes but they aren't appearing here in the comparison design :(
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord