Design comparison
SolutionDesign
Solution retrospective
Hi. This is my 2nd challenge. Would love to hear your suggestions and feedback. Thanks!
Community feedback
- @MojtabaMosaviPosted over 3 years ago
Hi, your solution looks nice and reponds well, the only things that come to mind are:
-
The way you implemented the social icons in the footer is totally fine and functional but I suggest next time you consider using a ul as container (more semantic markup).
-
Spend a lite time reading about how you can make icons accessible, A good place to start is here https://css-tricks.com/can-make-icon-system-accessible/.
Keep coding :)
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord