huddle landing page mobile first

Community feedback

• 

  Mark Mitchell•1,820

  @markup-mitchellPosted about 3 years ago

  Hi @VladimirBrscic, rather than make a technical recommendation, I'm going to give you some more general advice: it doesn't have to look exactly like the design!

  "pixel perfect" is a fine thing to try for, but if you have to compromise for the sake of responsiveness across devices, that's probably the right choice. There are times when accuracy matters and times when it doesn't, and I'd suggest that the placement of an abstract pattern background at one specific viewport size is a time when it doesn't.

  Your task was responsive, mobile-first site. Your designs were mobile and desktop. You've done a really good job.

  I would advise you to get rid of the background-position properties entirely.

  On a side note, you don't really need to use section elements here; main is fine to contain the image, header and text content, and the social media links would be better as a footer.

  Marked as helpful

  1

  ---

  

  VladimirBrscic•775

  @VladimirBrscicPosted about 3 years ago

  @markup-mitchell Thanks a lot for this review. I thought a lot actually about html so that advice is most welcoming as well.

  0