Design comparison
Solution retrospective
I did it this page like three times.. but I'm still not sure
Community feedback
- @elaineleungPosted about 2 years ago
Hi Hector, I think you did a great job here, and I'd be curious to know what are some things you're still unsure about. The site has good responsiveness where the mobile and desktop views are fairly optimal.
I think the only things I'd change are probably minor things like sizes, like for your container, I'd make it a bit wider using
width: min(100%, 70em)
, which means you wouldn't have to havewidth
andmax-width
together aswidth:min()
takes care of both. I'd also change the padding topadding: 0 3rem
just to make it look a bit more similar to the design screenshot. I'd give the hero section a bit more top and bottom padding, and I'd also addtext-align: left
for the footer links in the desktop view. These are just examples of the little tweaks you can do; on the whole, this looks pretty good to me, so well done!Marked as helpful0@hectorjbdPosted about 2 years ago@elaineleung Hi Elaine. It was difficult to make the footer responsive. Thanks for suggestion. It will be of great help to me for the rest of the challenges.
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord