Huddle Landing Page

Community feedback

• 

  Raymart Pamplona•16,100

  @pikapikamartPosted over 3 years ago

  Hey, good work on this one. Both layout in desktop and mobile is really good and it responds very well.

  Just some additions or suggestions:

  • do not nest your header on the main tag. This renders the header somewhat useless since it won't navigated properly by a screen reader. Have it in its own block

  <header></header>
  <main></main>
  

  • huddle logo could have the alt text huddle word, since it is the company's or websites name. This will be great especially when screen reader navigates on the header tag, it will read the image as its banner.
  • the social media icons should be wrapped on their own a tags along with their respective aria-labels. Example:

    <a href="#" aria-label="facebook">
      <i class="fab fa-facebook-f"></i> 
  </a>
  

  • your footer element should also be on its own block like the header

  header
  main
  footer
  

  Aside from those, really good job on this. Really responds well.

  Marked as helpful

  1
• 

  P

  Fluffy Kas•7,715

  @FluffyKasPosted over 3 years ago

  Hey, your solution looks really neat and it's nicely responsive. The only thing you should really do is to center your container perhaps!

  And to be nitpicky, you could look into using other units than pixels, like em, rem, ch, etc. ^^

  Marked as helpful

  1