Design comparison
Solution retrospective
I tried learning and using the BEM Naming Convention, but I am not sure I did it the right way. It would be very helpful to me if anybody can give me some pointers.
Also: How can I center the Font-Awesome Social icons properly inside of the circles?
I have been self-learing HTML and CSS since May 2021 and I want to become a developer, so any constructive criticism is very welcome. 😊
Community feedback
- @dvion0o0Posted over 3 years ago
Try to make it responsive since you are new to this you will gradually learn. great work here mobile view looks good 👍
0@royschrauwenPosted over 3 years ago@dvion0o0 Thank you for your feedback.
I tried to change the breakpoint where the site becomes responsive, so it switches better to desktop view.
Thanks for the kind words! 👍️
0 - @FarisPalayiPosted over 3 years ago
@royschrauwen Nice job on this one 👍
- Since font-awesome icons are fonts/texts, you can use most of the text/font related CSS properties. Here you can experiment with the
line-height
CSS property to make it in the center. - And also, even though I'm using my laptop to see your solution, I'm seeing the mobile version of the site. Try to use a smaller breakpoint in media queries.🙂
0@royschrauwenPosted over 3 years ago@FarisPalayi Thank you very much for your feedback! 👍️
-
I changed the media query breakpoint from 1440px to 1100px. That helped for me, I hope it also helps on your side.
-
Thank you for the tip about the
line-height
. It helped a lot with the positioning.
I appreciate you took the time to write some feedback. 💪
1@FarisPalayiPosted over 3 years ago@royschrauwen Yep. Now I get the desktop version 😃.
0 - Since font-awesome icons are fonts/texts, you can use most of the text/font related CSS properties. Here you can experiment with the
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord