Design comparison
Solution retrospective
I would love to know what you think.
Community feedback
- @codeswithrohPosted over 3 years ago
I created some pull-requests in your repo. I basically took care of the problems your web-page is facing. If you have any queries feel free to contact me.
0@zornicaShopovaPosted over 3 years ago@codeswithroh If you could give me an advice for the @media(...) . How to make it responsive without writing much code? Because i start to write @media(max-width: 1024px) for tablet but then it is not a fit for smaller...It is the same code all over again. I know is not the right way but i am confuse how to do it ?
0@codeswithrohPosted over 3 years ago@zornicaShopova Talking about responsiveness, its a big topic. So, I would suggest you to read this(https://learn.shayhowe.com/advanced-html-css/responsive-web-design/) article which helped me a lot to create responsiveness designs without a lot of code.
0 - @Vj3koPosted over 3 years ago
when hovering on one social icon, all 3 of them change color, u would wanna fix that. it is also not responsive, soon as when u get over 375 px the content goes way off the container. so when a person is using wider screen mobile or Ipad, ur content would not be viewable. try fixing this issues, everything else seems fine.
0@zornicaShopovaPosted over 3 years agoYes I couldn't figure out how to fix the problem with the icons . In the style-guide is written just 375px for mobile but i will add the rest of the screen sizes. That's the right way. Thank you.
0@Vj3koPosted over 3 years ago@zornicaShopova oh i got it now, u put 3 images for icons and 3 more images for different kind of color icons. its way easier to use icons from pages like: https://fontawesome.com/ u just need to register, and use their icons in any future project u might build. all u need to do is copy the cdn link to your <head> and search icons on their page for instance when u write facebook it shows u bunch of icons u can use, and just copy the link : "<i class="fab fa-facebook-f"></i>" to your social icons container and there u go. its a lot easier to work with, then u can use icon:hover just like u did with button:hover..... here is a link to explain how to use fontawesome icons : https://www.youtube.com/watch?v=wiw68Y-hPlA
0@zornicaShopovaPosted over 3 years agoI try this and it is so much easier and faster ! Thanks a lot !
0 - @frontendsultanPosted over 3 years ago
Overall work is good! But add some whitespace and give your illustration some space to breathe.
0
Please log in to post a comment
Log in with GitHub
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord