Huddle landing page - HTML/CSS

Community feedback

• 

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  Hey there! 👋 Here are some suggestions to help improve your code:

  Regarding your question,

  With mobile devices being the predominant way that people view websites/content. It is more crucial than ever to ensure that your website/content looks presentable on all mobile devices. To achieve this, you start building your website/content for smaller screen first and then adjust your content for larger screens.

  Remember, your are building your sites for your users, not for you. While it might better for you, it will be even better for your users.

  • The header should be outside of the main element.

  • The Alt Tag description in the logo needs to be improved upon. The description should state the company’s name.

  • The “Illustrations” serve no other purpose than to** be decorative**; They add no value. Their Alt Tag should left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • Your "buttons" were created with the incorrect element. When the user clicks on the button they should directed to a different part of you site. The Anchor Tag will achieve this.

  • Remove the Article elements you used to wrap you text. It's being used incorrectly.

  • There is no need for two footer elements. Place the "attribution" inside the main footer.

  • The “icons” (not the social media icons) in the footer are purely decorative, so their Alt Tag should be left blank and have an aria-hidden=“true” to hides it from assistive technology.

  • The footer links should only be one list, not two.

  • The “social media icons” are not decorative, they need to have an Alt Tag with a description.

  If you have any questions or need further clarification, feel free to reach out to me.

  Happy Coding! 🍂🦃

  Marked as helpful

  0
• 

  Luboš Bräth•650

  @Bredis79Posted about 2 years ago

  Hi @vcarames, thank you so much for your advices. Regarding the buttons...I didn't notice that the buttons are really bad and are not able to "redirect". I was focused on design and forgot also check the functionality. Next time I would use a link inside the button or use just a href and style it like button.

  I used the article to wrap the text just because I try to avoid simple div element....and maybe it isn't the best way:)

  In the next challenge I will start from mobile device.

  One more times thanks that you checked my solution and gave me some advices...Really appreciate it.

  Luboš

  0

  ---

  

  バレンタイン 😈•64,170

  @VCaramesPosted about 2 years ago

  @Bredis79

  1.That would be a wrong of creating a button. You can only use one element or the other, you cannot combine them.

  If you need an action then you will use a button element.

  If you need to direct your users to different parts of you site or externally, a Anchor Tag will do.

  Div will do the job for the majority of the time.

  I am glad that I was able to help you out! Keep it up!

  0