Huddle landing page html / scss with flex, that's all :)

Community feedback

• 

  T

  Matt Studdert•13,611

  @mattstuddertPosted over 4 years ago

  Nice work completing this challenge, Pierre, you've done a good job! Here are some pointers after taking a look at your solution:

  • Your responsive breakpoint could do with a review. At a tablet size, the text overlaps the illustration and is unreadable.
  • You're using some unnecessary div elements wrapped around the h1, p, and input. You could just style those elements directly instead of adding extra markup.
  • I would also use an anchor tag instead of an input. If this were a real landing page you'd expect it to link off to another page, so an anchor tag makes sense here. The social icons would also be wrapped in anchor tags as well.
  • Have you ever tried using min-width media queries instead of max-width? It's quite a common workflow with front-end developers to use them and work mobile-first. It can often lead to less CSS code and has the benefit of loading in fewer styles for mobile users, which can be a nice performance gain.

  Let me know if you have any questions. I hope this helps! 👍

  0