Design comparison
Solution retrospective
I appreciate any suggestion to improve my code! Feel free to tell me what I could have done better.
Community feedback
- @correlucasPosted over 2 years ago
๐พCiao Vittorio, congratulations for your new challenge solution!
I've looked your live site and everything seems good done, also the media query is working fine. The only thing you've missed are the font-size for the
h1
andparagraph
for the mobile version that are a little bit smaller than the desktop version/ So you need to add this font sizes inside the media query to allow the changes.Look the your hero image isn't displaying the proper size just because the
h1
in the mobile version is too big and to let it scale properly.The rest is just amazing, maybe if you want to improve a bit the semantics, you can use <section> replacing the div that wrap the h1, p and button.
Hope it helps, happy coding!
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord