huddle landing page -- frontend mentor challenge
Design comparison
Community feedback
- @HassiaiPosted almost 2 years ago
Replace the section tag with the main tag to fix the accessibility issues. There is no need for the <br> in the html. you forgot to add the social media icons to the page.
There is no need to give the body a width value and overflow value.
The background-image is not visible because the folder images is not in your repository. to make it visible remove "images/" from the url value,
url(bg-desktop.svg)
instead of url(images/bg-desktop.svg), add a background-size of cover to the body.Give the img a max-width of 100% for a responsive content.
Use relative units like rem or em as unit for the padding, margin, width values and preferably rem for the font-size values, instead of using px which is an absolute unit. For more on CSS units Click here
You forgot to add a media query for the mobile design, i will advise you always begin with mobile design first this will make the process a bit easier.
Hope am helpful.
Well done for completing this challenge. HAPPY CODING
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord