Design comparison
Solution retrospective
thanks for your time all feedbacks are welcome
Community feedback
- @correlucasPosted about 2 years ago
👾Hello @JulienK94, Congratulations on completing this challenge!
Here's some tips for you:
1.I saw that for some properties you’ve used
rem
and for otherspx
. In this case it is better to use only one kind of unit to have a better organization for your code.relative units
asrem
orem
that have a better fit if you want your site more accessible between different screen sizes and devices.REM
andEM
does not just apply to font size, but to all sizes as well.2.Use a CSS reset to avoid all the problems you can have with the default CSS setup, removing all margins, making the images easier to work, see the article below where you can copy and paste this css code cheatsheet: https://piccalil.li/blog/a-modern-css-reset/
3.To reduce your css file and improve the performance loading your page you can use a tool called
css minify
that reduces the css code removing the unnecessary characters. You can use aVSCode
plugin calledminify css
or this website tool to reduce your code:https://www.toptal.com/developers/cssminifier
✌️ I hope this helps you and happy coding!
Marked as helpful0@JulienK94Posted about 2 years ago@correlucas thanks for the advice i am going to check it asap
0 - @hyrongennikePosted about 2 years ago
Hi @JulienK94,
Congrats on completing the challenge
The icon don't look like complete circles you can add the following to fix that.
.icon a { width: 50px; height: 50px; display: flex; justify-content: center; align-items: center; text-decoration: none; }
Also check the report above there are quite a few issue. Hope this is helpful.
Marked as helpful0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord