Huddle landing page CSS Flexbox, Grid, Sass, JS form validation

Community feedback

• 

  T

  ApplePieGiraffe•30,545

  @ApplePieGiraffePosted almost 4 years ago

  Hello there, Marta! 👋

  It's always nice to see you complete another challenge! 😀 Good job on this one! 🙌 Your solution looks good and responds well! 👍

  I think it's fine to add some initial styles for things like text and then override them later with classes. I think using BEM nicely helps one keep track of modifier classes, too. For example, you might add color: var(--very-dark-blue) to the body but later add a class named paragraph--white to a paragraph element to change the color then. 😉

  A few things I'd like to suggest are,

  • Adding a max-width to the main container or wrapper of the page to prevent the content of the page from becoming too stretched on extra-large screens (and also to prevent the hero image from becoming too big when the width of the screen increases).
  • Making sure the submit button next to the form in the footer of the page remains in its place in the desktop layout when the error message for the form appears (currently, it jumps down suddenly when the error message appears).

  As usual, keep coding (and happy coding, too)! 😁

  2