Design comparison
Community feedback
- @hossam-khalafPosted about 2 years ago
Thanks, @vcarames for Your Valuable feedback
Ready To Build Your Community" is already an H3 heading.
going to work on them right away:)
Have a great day
0@VCaramesPosted about 2 years ago@hossam-khalaf
Sorry it was suppose to say
h2
.I am glad that I was able to help you out! Keep it up!
0 - @VCaramesPosted about 2 years ago
Hey there! 👋 Here are some suggestions to help improve your code:
-
There needs to be a
main
element wrapping your main content. -
The “Illustrations” serve no other purpose than to** be decorative**; They add no value. Their
Alt Tag
should left blank and have anaria-hidden=“true”
to hides it from assistive technology. -
"Ready To Build Your Community" should be an
H3
heading. -
The
footer
“phone” and “address” should be wrapped inAnchor Tags
, so users can easily click on them and have the appropriate app open for them. -
The
footer
links need to be wrapped inside anav
element and should only be one single list. -
The “social media icons” are not decorative, they need to have an
Alt Tag
with a description. -
Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
If you have any questions or need further clarification, feel free to reach out to me.
Happy Coding! 🍂🦃
0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord