Design comparison
Solution retrospective
Very enjoyable challenge to code! It really tested my knowledge with css grid and flexbox as well as responsiveness! As per usual, any comments or advice are welcomeπ
Community feedback
- @VCaramesPosted almost 2 years ago
Hey there! π Here is some feedback to further improve your code:
- The
section
element is being used incorrectly β οΈ and not needed for this challenge .
- That is not β how you write an
alt tag
description for a logo. It should only state the company name.
- Every site should ALWAYS have β
a
main
element not only for semantic purposes but also to help assistive technology find the main content of your content. For this challenge, containerhero__container-left
andhero__container-right
should both be wrapped inside amain
element.
More Info: π
- This LINK is not β a navigation menu. So it should not be wrapped in a
nav
element.
- ALWAYS Implement a "Mobile First" approach π± > π₯
Mobile devices are now the dominant π way in which people browse the web, it is critical that your website/content looks perfect π― on all mobile devices.
More Info: π
If you have any questions or need further clarification, you can always check out my submission and/or feel free to reach out to me.
Happy Coding! πΎ
Marked as helpful1@jCasiaPosted almost 2 years ago@vcarames Thank you for the feedback, I would definitely keep this in mindπ
1 - The
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord