Design comparison
SolutionDesign
Solution retrospective
Had some difficulties so please take a look and tell me how i can improve my code(for large screens per exapmle). Couldnt get the border around the icons to work.
Community feedback
- @0xabdulkhaliqPosted over 1 year ago
Hello there 👋. Congratulations on successfully completing the challenge! 🎉
- I have other recommendations regarding your code that I believe will be of great interest to you.
COMPONENT MEASUREMENTS 📐:
- Use
min-height: 100vh
for.container
instead ofheight: 90vh
. Setting theheight: 90vh
may result in the component being cut off on smaller screens.
- For example; if we set
height: 90vh
then the.container
will have90vh
height no matter what. Even if the content spans more than90vh
of viewport.
- But if we set
min-height: 100vh
then the.container
will start at100vh
, if the content pushes the.container
beyond100vh
it will continue growing. However if you have content that takes less than100vh
it will still take100vh
in space.
.
I hope you find this helpful 😄 Above all, the solution you submitted is great !
Happy coding!
Marked as helpful0@Andigashi1Posted over 1 year ago@0xAbdulKhalid i noticed the comment after i fixed that issue but thank you. Any tips on how to fix the icons because i couldnt find how to do it would be very appreciated
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord