Design comparison
Solution retrospective
It was a challenging project. I practiced learning SASS and cube CSS with this project.
I have yet to make it accessible. If you have any suggestions or feedback to make it accessible. I would really appreciate it.
Community feedback
- @vanzasetiaPosted over 2 years ago
Hi, Pradeep Saini! 👋
Great work on this challenge! Your solution looks pretty good! 😀
Some suggestions from me about accessibility.
- Create a custom
:focus-visible
styling for any interactive elements (button
, links,input
,textarea
). This will let people who use a keyboard to navigate the site know where they are currently on the page. - Remove the word "logo" from the alternative text of the logo. The screenreader would pronounce it as an image already.
- Links must have text content in order to be accessible by screenreader users. So, I recommend using
aria-label
attribute to give some text content to all social media links. - Lastly, I suggest fixing all the issues that have been reported.
I hope this helps! Keep up the good work! 👍
Marked as helpful1@pradeeps4iniPosted over 2 years ago@vanzasetia Thanks for all the feedbacks. Issues reported were regarding the alt text i provided to the <a> links. But i think aria-label is what i should've used.
0@vanzasetiaPosted over 2 years ago@pradeeps4ini You are welcome! 👍
You can't have an
alt
attribute on an anchor tag. It's invalid HTML. 🙂0 - Create a custom
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord