Huddle Landing Page

Community feedback

• 

  Vanza Setia•27,775

  @vanzasetiaPosted about 2 years ago

  Hi, Rachel! 👋

  Congratulations on finishing this challenge! 🎉 It's amazing that you can create your own social media icons. Those icons look the same as the original design. 👏

  Here are some suggestions for improvements.

  • The alternative text of the logo should not contain the word "logo". The semantic meaning of the img element is already enough.
  • Not every image needs alt text. If the image does not provide any meaningful content, such as the illustration-mockups.svg, consider using empty alt text (alt=””). This saves your screen reader users time as they navigate the page.
  • I recommend taking a look at "Quick tip: Using alt text properly - The A11Y Project".
  • Always specify the type of the button. In this case, set the type of them as type="button". It will prevent the button from behaving unexpectedly.
  • Wrap each of the social media icons with an anchor tag. They are social media links of the company.
  • Use the em unit for media queries. It adapts when the users change their font size setting. Here are some references.
    • @media - CSS: Cascading Style Sheets | MDN #accessibility_concerns
    • PX, EM or REM Media Queries?

  I hope this helps. Happy coding!

  0