Huddle landing page

Community feedback

• 

  Ouattara•200

  @Kaji17Posted over 1 year ago

  **Helo @minnieme20 congratulation for your solution ** I have some tips to increase your code and good practice.

  • 01 it is important to put an alternative text in tag <img> with properties alt :

  • <img src="images/logo.svg" class="logo" alt="logo">

  • 02 for more semanctic it preferable to use <h1> <h2> ... for display title in your page. Use <h1> for title 'Build The Community Your Fans Will Love'. ```<h1 class="main-p">Build The Community Your Fans Will Love</h1>`

  • 03 set attribute 'type' in tag <button>: <button type="button">Register</button>

  • 04 for display social media icon instead of putting class="social" in position="fixed" you can put this container inside the info div class="info" in position="relative " and class="social" in position="absolute " like the class="social" will adapt according to changes in class="info". I hope it will help you

  Marked as helpful

  0
• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HTML 🏷️:

  • This solution generates accessibility error reports, "All page content should be contained by landmarks" is due to non-semantic markup, which lack landmark for a webpage

  ---

  • So fix it by replacing the <div class="container"> element with the semantic element <main> in your index.html file to improve accessibility and organization of your page.

  ---

  • What is meant by landmark ?, They used to define major sections of your page instead of relying on generic elements like <div> or <span>

  ---

  • They convey the structure of your page. For example, the <main> element should include all content directly related to the page's main idea, so there should only be one per page

  ---

  iMAGES 📸:

  • alt text is a descriptive text attribute added to an HTML image tag that provides a textual description of an image for users who are visually impaired or cannot see the image for any other reason.

  ---

  • The purpose of alt text is to convey the meaning and context of an image to these users so that they can understand the content and information conveyed by the image.

  ---

  • But here, The svg's are just used as a decoration material.

  ---

  • Meanwhile it also needs an alt attribute with empty value

  ---

  • Eg: <img src="./images/illustration-mockups.svg" alt="" aria-hidden="true">

  ---

  HEADINGS ⚠️:

  ---

  • And, this solution has also generated accessibility error report due to lack of level-one heading <h1>

  ---

  • Every site must want at least one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0