Design comparison
Community feedback
- @VCaramesPosted about 2 years ago
Hey @tbahd, some suggestions to improve you code:
-
The Alt Tag description in the logo needs to be improved upon. The logo is arguably the most important image in you page. So the description should state the company name and what it is.
-
The Alt Tag description in the social media icons needs to be improved upon. They need to state what they are and were it will lead users to when clicked on.
-
Add the following to your Body Element to fix your background and change the
height
tomin-height
.
body{ background-size: cover; background-position: center ; }
- Your CSS Reset is extremely bare and being underutilized. To fully maximize your CSS reset, you want to add more to it.
Here are few CSS Resets that you can look at and use to create your own or just copy and paste one that is already prebuilt.
https://www.joshwcomeau.com/css/custom-css-reset/
https://meyerweb.com/eric/tools/css/reset/
http://html5doctor.com/html-5-reset-stylesheet/
Happy Coding!
Marked as helpful0 -
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord