Design comparison
SolutionDesign
Solution retrospective
Hii, I hope you're doing good. If anything is wrong with this please let me know. Keep Learning, Keep Exploring. Thanks!!
Community feedback
- @DavidMorgadePosted about 2 years ago
Hello Suraj, congrats on getting the solution to the challenge!
If you don't mind I would like to give you some suggestions:
- I noticed that you used
transition
on your buttons, but take a closer look, when you leave the mouse from the button, the transition doesn't work, it only works on hover not when moving the mouse out! wich would give it a smoother effect in my opinion, to fix this you just have to add yourtransition
on the element and not on the:hover
pseudoelement.
The rest of your CSS seems to be fine for me! your site looks responsive and adapts well to diferent screen sizes.
- I would also change a bit your html structure, try using some
main
,section
andarticle
tags, instead of alldivs
for the content of the page! For example, your firstdiv
after the header could be themain
divided in somesections
and thecards
class asarticle
.
Hope my feedback helps you!, if you have any questions don't hesitate to ask, great work and keep going with those challenges!
Marked as helpful0 - I noticed that you used
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord