Huddle Landing Page

Community feedback

• 

  Shashree Samuel•9,260

  @shashreesamuelPosted over 2 years ago

  Hey good job completing this challenge

  Keep up the good work

  Your solution looks great however I think that the description on the right of the image has a bit too much line-height. Secondly I think that the description needs some margin from the bottom using margin-bottom

  I hope this helps

  Cheers Happy coding 👍

  Marked as helpful

  1
• 

  T

  Grace•31,010

  @grace-snowPosted over 2 years ago

  Hello again

  Looking purely at semantics on this, it's not far off but I see 3 issues

  1. Is this product / site called "company brand"? If not, that alt needs to change!

  2. What do you expect to happen when someone clicks register? Buttons are for actions, anchor tags are for navigation

  3. When you see social icons what do you expect to be able to do? In every scenario I've ever seen, those icons are clickable. That means more anchor tags. The important differences with these though are that a) they need to open on a new page as they would navigate away from this site and b) they would need labelling as icons like that are effectively hidden from the dom. That means either including some Sr only text (look it up) or some aria to ensure they can be read by search engines and screenreaders

  0