Huddle Landing Page 1st attempt

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted 7 months ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have a suggestion regarding your code that I believe will be of great interest to you.

  ---

  ANCHOR ELEMENT 🔴:

  • The social icons which are added by using <i> elements are not for decorative purposes.

  <div class="smedialinks">
     <i class="fa-brands fa-facebook-f" aria-hidden="true"></i>
     <i class="fa-brands fa-twitter" aria-hidden="true"></i>
     <i class="fa-brands fa-instagram" aria-hidden="true"></i>
  </div>
  

  ---

  • Those elements are needed to be wrapped by <a> elements along with proper aria-label attribute which is way more important for social links in an <a> tag can help provide more context to users with visual impairments who use assistive technologies such as screen readers to access your website.

  ---

  • When a screen reader encounters an anchor tag with a social link, it may announce the link's text content, such as "Facebook" or "Twitter," by including an aria-label attribute that points to a nearby element containing a description of the link's purpose, you can provide more context and clarity to the user.

  ---

  • By providing this additional information, you can help users with visual impairments to better understand the purpose and value of social links, and encourage them to engage with your content. This can ultimately improve the user experience on your website, and make it more accessible and inclusive for all users.

  ---

  • Example:

  <a href="#" aria-label="Facebook profile of Huddle">
      <i class="fa-brands fa-facebook-f" aria-hidden="true"></i>
  </a>
  

  ---

  • If you have any questions or need further clarification, you can always check out my submission for this challenge and/or feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  Marked as helpful

  0
• 

  Godstime Nwabue•150

  @GodstimeNwabuePosted 7 months ago

  Hi Kari,

  Kudos on the design! It's great, but there's room for improvement. I still remember when I attempted this design, but you've put in a lot of effort. Firstly, your social media border isn't well-defined, and on mobile, it's not aligning to the center. These are my feedback points for you.

  Marked as helpful

  0