Design comparison
Solution retrospective
I wonder how to make circle border around the social network icons .. "because the circles isn't the same size if i make it as a border "[ the icons from FontAwesome] how to make it look similar and good as the image in the template ?
and When i hover on the button the content is moving so i disabled that the fonts changed because of that .. Thanks For The Template ❤
Community feedback
- @pikapikamartPosted about 3 years ago
Hey, awesome work on this one. Desktop layout looks great, site is responsive and the mobile state looks great.
On this one, what you should have done is wrap the
i
tag that contains the icon inside of aa
tag, and on thea
tag, make it a circle and match like on the design.Some other suggestions would be:
- It would be great to have a base styling of this:
html { box-sizing: border-boxl font-size: 100%; } *, *::before, *::after { box-sizing: inherit }
This way, handling an element specially its size will be easier because of the
box-sizing
- Always have a
main
element to wrap the main content of the site. For this usemain
tag on the.container
selector. - But to be honest, a preferred markup on this one would be:
<header /> # contains the logo <main /> # main content <footer /> # the social-media links
- Remember that a website-logo is one of the meaningful images on a site so use proper
alt
for it. Use the website's name as the value likealt="huddle"
. - The hero-section image could use an extra
aria-hidden="true"
so that it will be totally hidden for screen-reader users. - You don't need to use
position: absolute
on the.social
selector. Since you are just using this styling to make the element on the right side, you could instead use these stylings:
max-width: max-content: margin-left: auto;
- Those social-media links could be inside a
ul
element since those are "list" of links. - Each
a
tag that wraps the social-media icon should have eitheraria-label
attribute orsr-only
text inside it, defining where the link would take them. For example, you should usefacebook
as the value if the link would take the user to facebook.
Aside from those, great job again on this one.
Marked as helpful1@AhmedFawzi44Posted about 3 years ago@pikamart Thanks a Lot !! This feedback is really helpful ! i learned many things from it ! Thanks ❤❤
1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord