Design comparison
SolutionDesign
Solution retrospective
I will be happy to hear your comment
Community feedback
- @tesla-ambassadorPosted over 2 years ago
Hey Ibrahim! This is a pretty solid solution, congratulations on completing the challenge. Here's a few pointers:
- The website is pretty responsive but the components are too small on some screen widths therefore, you should consider changing the flex-direction to column at the screen width of 850px and maybe increse the width of the container containing you text and image to like 90% so that your content is easily visible.
- You might want to add an
aria-label = "text describing link"
attribute to enable the browser to easily describe your link and this will fix your accessiblity issues. - You cannot contain the
<main>
landmark within a<header>
because they are both landmarks that are meant to distinguish different sections of your code. This will fix your HTML validation issues.
Happy coding and keep up the good work! π
Marked as helpful0@Ibrahim-EltoukhyPosted over 2 years ago@tesla-ambassador thank you very much for your helpful comment
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord