@jesse10930
Posted
Hi Kris, great job on this project! It looks great! I can't answer your question about SVGs, as I'm not too familiar with how to use them.
To your second question about the smaller screen sizes, the HTML for the SVG with a class of 'container__col1--img' has a 'height="506"' attribute, which is preventing the height of that div to be responsive. So as the screen width gets smaller, the image is responding but the container's height is staying constant, which gives the appearance of those margins. If you add:
svg.container__col1--img {
height: auto;
}
to the media query for smaller screens, I think that will fix the issue.
To your last question, if we set a max-width to 1440px, it could have adverse effects for anyone using your app on a large monitor. I think they give us that info just so we know the relative size of the screenshots we are looking at. But again, not something I'm sure of.
Anyway, hope this is helpful! Happy coding!
@krisp-dev
Posted
@jesse10930 Hi Jesse, thanks for your answer!
The 'height: auto;' did indeed fix the issue! :) As for the 1440px I might just resize my screen to 1440px and try to match the design rather than setting the max-width, and if needed adjust for bigger screens with a media query.