Design comparison
SolutionDesign
Community feedback
- @MelvinAguilarPosted almost 2 years ago
Hello there ๐. Good job on completing the challenge !
I have some suggestions about your code that might interest you.
- A logo is not considered a decoration in HTML because it is often a crucial part of a website's branding and identity, use company name as the alt attribute value for logos. The word "logo" is not necessary.
- Social media icons, which are often used to link to a company's social media profiles, should typically be anchor elements because anchor elements allows users to easily click on the icon and be taken directly to the company's social media profile page. This makes it easy for users to connect with the company on social media.
- Do illustrations add context to the text or are they just for decoration? Use an empty alt attribute for decorative images. It indicates to screen readers that the image is not important and can be ignored, reducing unnecessary noise for users.
- Wrap the unordered list (
About Us
,Contact
,Try for Free
) with navigation links in a<nav>
tag, this provides additional semantics for the group of links, indicating that it is a navigation section.
- All the paragraphs "About Us", "What We Do", "FAQ", "Career", "Blog" and "Contact Us" should be links in an unordered list and that unordered list should be inside a
<nav>
tag.
-
If in your page you have more than one
nav
tag, you should use thearia-label
attribute to describe and identify the navigation and make it unique. Note: You don't need to add the word "navigation" to thearia-label
value because screen readers will announce the element as a navigation automatically.Example:
<nav aria-label="main"> <ul>...</ul> </nav> <nav aria-label="footer"> <ul>...</ul> </nav>
I hope you find it useful! ๐
Happy coding!
Marked as helpful1
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord