Huddle - By Deja

Community feedback

• 

  T

  Grace•31,090

  @grace-snowPosted over 3 years ago

  Hi

  This looks good overall and has nice semantic structure. There are a few issues that need fixing though

  • learn more button: if including a button element, always include a type. That said, this should actually be an anchor tag element as it would trigger navigation in a real site.
  • your social links need visually-hidden text or an aria-label to make them accessible to search engines and assistive technology (at the moment, screenreader would just announce "link" without being able to say where that link goes)
  • social links go to external sites. Therefore it's usual practice to make them open in a new tab and include the following attributes: `target="_blank" rel="noopener" aria-label="Facebook (opens in new window)"
  • add focus-visible states to all interactive elements so keyboard users know where they are on the page
  • very important not to use viewport units for font-sizes! At the moment text becomes completely unreadable at some screen sizes. Instead use rem. If you are really keen to include responsive font-sizing, look into the clamp property. There are some good articles about it on CSS Tricks / Smashing mag. I would probably only use it for headings or hero blocks. It could be very disorientating for users to have text changing sizes on large blocks of text, so tread very carefully. There isn't usually a need to change text sizes very often

  Well done again

  Marked as helpful

  2
• 

  Vanza Setia•27,775

  @vanzasetiaPosted over 3 years ago

  👋 Hi Deja! My name is Vanza!

  I have some feedback to improve this solution and also tips on write a clean CSS:

  • In my opinion, max-width: 85% on main is too small if the width of the user screen size is below 400px, to fix this try to increase the max-width.
  • Your HTML is clean, but to write a cleaner CSS, try to follow CSS Guidelines.

  That's it! Hopefully this is useful!

  🔥Keep on Learning!🔥

  Marked as helpful

  1
• 

  bambino•340

  @Bambino143Posted over 3 years ago

  clean enough 🙃 nice work🚀🚀

  1