Hubble landing page as a first practicing project

Community feedback

• 

  Adarsh Pratap•5,515

  @adarshcodesPosted over 4 years ago

  Hi! @marcomedeirosfh, Congratulations on submitting your first solution on the front-end mentor🙂.

  1. About your design:

  • It looks nice, you can increase the font-size a bit of main-heading.

  2. About your responsiveness:

  • Add few more breakpoints like at 1055px, 680px and at 480px.

  3. About your code:

  • The code looks pretty clean.

  4. Accessibility and HTML issues:

  • Great👍 no issues.

  Keep Coding🐱‍💻

  1
• 

  Ksenia•1,350

  @kseniusPosted over 4 years ago

  Hi! Congratulations on your first project!

  I've looked at the preview and code of your site and I'd like to make a couple of suggestions:

  1. I'd recommend not to use ID selectors in CSS. Using classes is more convenient and beneficial. Here's the article about the reasons.

  I'd also recommend you to learn more about different approaches to CSS, such as CSS naming conventions, for example BEM methodology. It really helps to organize code better, not only CSS but also HTML. Personally my code has become much better with BEM.

  2. The second suggestion is about responsiveness. Your site is displayed incorrectly between 376px and approximately 1000px. You can solve this by increasing the value of your breakpoint (375px), for example.

  1

  ---

  

  marcomedeirosfh•40

  @marcomedeirosfhPosted over 4 years ago

  Hi @ksenius !

  I will definitely keep your feedback in mind for my next project.

  Thanks a lot for your feedback!

  0