Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

https://www.youtube.com/watch?v=CQLgYgXxP4I

@Jessdantas

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Community feedback

Adriano 34,090

@AdrianoEscarabote

Posted

Olá Jéssica Dantas da Silva, tudo bem? Gostei muito do resultado do seu projeto, mas tenho algumas dicas que acho que você vai gostar:

Percebi que uma imagem não está sendo carregada na página, para corrigir podemos fazer assim:

<img src="./images/icon-view.svg" alt="images icon">

Para melhorar a acessibilidade do projeto, você poderia ter colocado um arquivo h1. Cada página deve conter um cabeçalho de nível 1, para que as pessoas que usam leitores de tela identifiquem qual é o cabeçalho principal.

Prefira usar rem em vez de px para que uma página funcione melhor em todos os navegadores e redimensione os elementos de acordo.

O resto é ótimo!

Espero que ajude... 👍

Marked as helpful

0

@Jessdantas

Posted

@AdrianoEscarabote Olá, tudo ótimo! Agradeço pelas dicas vai me ajudar muito.

0
Travolgi 🍕 31,420

@denielden

Posted

Hello Jessica, You have done a good work! 😁

Some little tips to improve your code:

  • add main tag and wrap the card for improve the Accessibility
  • also you can use article tag instead of a simple div to the container card for improve the Accessibility
  • remove all margin from .container class because with flex they are superfluous
  • fix the src of eye icon image like this: src="images/icon-view.svg" or src="./images/icon-view.svg" but not with only / slash
  • use display: grid and place-items: center to img-overlay class instead of absolute positioning in the .img-overlay img class to cenmter the eye icon on hover
  • add transition on the element with hover effect
  • instead of using px use relative units of measurement like rem -> read here

Keep learning how to code with your amazing solutions to challenges.

Hope this help 😉 and Happy coding!

Marked as helpful

0

Travolgi 🍕 31,420

@denielden

Posted

@Jessdantas you are welcome and keep it up :)

Marked as helpful

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord