https://github.com/Samjolas/rating-card

Community feedback

• 

  msiesse•50

  @msiessePosted about 2 years ago

  Hello Samuel ! Nice job completing the challenge !

  I’ve seen a little mistake on your live site, it looks like it’s possible to select multiple value for rating. So when we select a value like 5 for example and then we select 4, the previous choice is not unfocused.

  0
• 

  Travolgi 🍕•31,400

  @denieldenPosted about 2 years ago

  Hi Samuel, congratulations on completing the challenge, great job! 😁

  Some little tips for optimizing your code:

  • istead of using ul > li for the number of stars value use input type="checkbox" and improve the Accessibility
  • also you can wrap all the input type="checkbox" with form tag
  • add transition on the element with hover effect
  • add javascript controll: i can submit without selection

  Hope this help! Happy coding 😉

  0