@ownedbyanonymous
Posted
Hie Papi 👋🏾, Your solution is impressive 🔥🔥. It shows that you put a great deal of work and effort into crafting your solution, well done 👏🏾.
Here are a few areas l picked up while going through your code base that might need some improvements.
- Use of semantic tags Semantic tags relay the meaning of the content they contain which can help improve accessibility of your web page. For instance, instead of wrapping the profile image, name, and title inside a div (which is a non-semantic tag), you could wrap them inside a header tag. Also instead of wrapping the name instead of a div you could also wrap inside a h5 or one of the heading tags
<article class="card card-1">
<header>
<img src="./images/image-daniel.jpg" alt="">
<div class="card__user">
<h5 class="name">Daniel Clifford</h5>
<p class="title">Verified Graduate</p>
</div>
</header>
</article>
HTML5 allows us to nest a section inside of an article and an article inside a section. My suggestion is to wrap the card-heading and card-detail inside a section tag and you could also use an h2 heading or one of the heading elements for the card-heading instead of using a div.
Hope you find my feedback helpful and if you have any questions or want to discuss the challenge you are more than welcome to reach out. Please mark this comment as useful if you found it helpful.
Marked as helpful
@Papi84
Posted
@ownedbyanonymous Thank you so much for the feedback and kind words! 😊 I really appreciate the time you took to review my solution and for highlighting areas of improvement.
Your suggestions regarding the use of semantic tags make a lot of sense, especially for accessibility and structuring the HTML more effectively. I’ll definitely implement the changes you recommended, like using the <header> tag and the appropriate heading elements for better organization of the content.
I’m still learning and refining my skills, so this kind of feedback is incredibly valuable to me. Thanks again for your thoughtful input! 🙌🏾
