Skip to content
Submitted over 2 years ago

https://github.com/nironwp/qr-code-challenge

Pedro Lucas Mendes Souza•100
@nironwp
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...QR code component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I had difficulty in aligning the h1 and the paragraph, and I think I could have done the image and its resizing in another way, but overall what can I improve?

Community feedback

  • TechNech•340
    @TechNechPosted over 2 years ago

    Hi, good works it almost looks similiar to the design. I think you don't need to change any of it.

    • You don't have any .container property setup in CSS, I suggest you set it.
    • Also on your qr class add display: flex; then you can align items to center just justify-content and align-items.
    • I see in code you have added script tag which isn't used, so remove that.

    Always try to use semantic HTML5 tags instead of a lot div, it will keep your code cleaner. The rest is good work!

    Happy Coding! :)

    Marked as helpful
    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord