Skip to content
Submitted almost 3 years ago

https://github.com/MSA-new/CSS-Card-Challenge.git

MSA-new•30
@MSA-new
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...NFT preview card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

CSS-card I restarted the challenge

Hello everyone.. I wanted to Thank you for your answers.. it helped me practice and write the code correctly..

Thank you very much..

Community feedback

  • Martin Eliáš•890
    @martinelias1312Posted almost 3 years ago

    Hello @MSA-new,

    i suggest to:

    • change .img-container { border-radius: 10px; } to 13px, because of visible cyan borders
    • wrap <div class="attribution"> in a <footer> element for better accessibility
    • missing <h1> element, there should be also one for better accessibility. Article about it here.
    • for more responsiveness, you can use relative units - em, rem, %.. and max-width instead of width. Article here.

    Hope this helps for future projects :)

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord