Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found
Not Found

Submitted

https://github.com/MSA-new/CSS-Card-Challenge.git

MSA-new 30

@MSA-new

Desktop design screenshot for the NFT preview card component coding challenge

This is a solution for...

  • HTML
  • CSS
1newbie
View challenge

Design comparison


SolutionDesign

Solution retrospective


CSS-card I restarted the challenge

Hello everyone.. I wanted to Thank you for your answers.. it helped me practice and write the code correctly..

Thank you very much..

Community feedback

@martinelias1312

Posted

Hello @MSA-new,

i suggest to:

  • change .img-container { border-radius: 10px; } to 13px, because of visible cyan borders
  • wrap <div class="attribution"> in a <footer> element for better accessibility
  • missing <h1> element, there should be also one for better accessibility. Article about it here.
  • for more responsiveness, you can use relative units - em, rem, %.. and max-width instead of width. Article here.

Hope this helps for future projects :)

0

Please log in to post a comment

Log in with GitHub
Discord logo

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord