Submitted over 1 year ago
https://github.com/Amir837/sunnyside-Landing-Page-FChallenge
@Amir837
Design comparison
SolutionDesign
Solution retrospective
Been a while since I've completed a challenge here.
From this exercise found that this is the best method (at least for me) to add some images on website. What do you think about it? (you only need to setup size)
<div class = "egg" />Community feedback
- @ChamuMutezvaPosted over 1 year ago
Hi Amir
Having checked your work , here is some of my observation
- the logo is an image, having said that ,since it is the logo , it should have been wrapped in a link element as that would be a link to the home page in a real website.
- a div element is an element of last resort, it has no semantic meaning and should only be used when there is no other element that can do the work better. The element to use for links , is the anchor element and click events should be handled by buttons. Do not use an image or div as an interactive element.
- Positioning of the navigation is done using CSS, you shouldn't be having 2 navigations
- for best practice, a site should have one h1 element
- the social icons , are not just images , but should be links to social media sites. I would expect an unordered list with anchor elements and each anchor element with an image as a child
- for a complete reset, look for andy bell's modern reset stylesheet
- Font-sizes should be in rems , not px values.
I would encourage you , to start with the QR code challenge and get feedback. Then come back to this one at a later stage.
0
Please log in to post a comment
Log in with GitHubJoin our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord