
Design comparison
Solution retrospective
Hey developers,
I've just pushed my code online and would love your input! If you have a moment, could you please take a look and share any suggestions or improvements? Your expertise is invaluable, and I'm eager to enhance my project. Thanks a bunch!
Repository Link: [https://calculator-app-ahmar-iftikhar.netlify.app/ ] \ https://github.com/AhmarIftikhar123/Calculator-app
Cheers, [Your Name]
Please log in to post a comment
Log in with GitHubCommunity feedback
- P@LucianoDLima
Well done on completing this challenge! I remember trying once a few months ago and giving up because I was finding it so hard haha so good job
Here's some feedback, starting with bugs I found:
- Currently the user can input a bunch of dots, and this should not be allowed, so you might wanna add some regex to take care of that. (For example, I can type 5 + 5.5.5.5....5.5.5 and so on)
- If I input, any number divided by 0, then try to add, it throws a console error, but no UI error. Try the following to reproduce the error: 5 / 0, press = , then add 5 +
- If user tries to del the numbers after doing some math, the delete actually deletes the result one by one too. How to reproduce: 222 + 222 =, then input a few other numbers and try to delete
- The mobile version doesn't have enough padding between the result and the input box
Feedback not related to bugs:
- Look up LocalStorage in javascript, with this you can save the theme the user picks, and save it across sections. For example, if I like the theme 3, you save it locally with localStorage, then if I refresh the page, it will still be with the theme 3 selected
Marked as helpful
Join our Discord community
Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!
Join our Discord