HTML,Vanila(Css,Js).

Community feedback

• 

  P

  Luciano Lima•1,290

  @LucianoDLimaPosted 10 months ago

  Well done on completing this challenge! I remember trying once a few months ago and giving up because I was finding it so hard haha so good job

  Here's some feedback, starting with bugs I found:

  1. Currently the user can input a bunch of dots, and this should not be allowed, so you might wanna add some regex to take care of that. (For example, I can type 5 + 5.5.5.5....5.5.5 and so on)
  2. If I input, any number divided by 0, then try to add, it throws a console error, but no UI error. Try the following to reproduce the error: 5 / 0, press = , then add 5 +
  3. If user tries to del the numbers after doing some math, the delete actually deletes the result one by one too. How to reproduce: 222 + 222 =, then input a few other numbers and try to delete
  4. The mobile version doesn't have enough padding between the result and the input box

  Feedback not related to bugs:

  1. Look up LocalStorage in javascript, with this you can save the theme the user picks, and save it across sections. For example, if I like the theme 3, you save it locally with localStorage, then if I refresh the page, it will still be with the theme 3 selected

  Marked as helpful

  1

  ---

  

  AhmarIftikhar123•660

  @AhmarIftikhar123Posted 10 months ago

  @LucianoDLima Thank you very much.Your comment is very helpful for me. I'm fix all the bugs you mention.Please! review my code and gave and tell me if any bug remains in the code.

  0