HTML/SCSS - Result Summary Component

Community feedback

• 

  Abdul Khaliq 🚀•72,560

  @0xabdulkhaliqPosted over 1 year ago

  Hello there 👋. Congratulations on successfully completing the challenge! 🎉

  • I have other recommendations regarding your code that I believe will be of great interest to you.

  ---

  HEADINGS ⚠️:

  • This solution lacks usage of <h1> so it can cause severe accessibility errors due to lack of level-one headings <h1>

  ---

  • Every site must want only one h1 element identifying and describing the main content of the page.

  ---

  • An h1 heading provides an important navigation point for users of assistive technologies, allowing them to easily find the main content of the page.

  ---

  • So we want to add a level-one heading to improve accessibility by reading aloud the heading by screen readers, you can achieve this by adding a sr-only class to hide it from visual users (it will be useful for visually impaired users)

  ---

  • Example: <h1 class="sr-only">Results summary component</h1>

  ---

  • If you have any questions or need further clarification, you can always check out my submission for another challenge where i used this technique and feel free to reach out to me.

  ---

  .

  I hope you find this helpful 😄 Above all, the solution you submitted is great !

  Happy coding!

  0
• 

  Kamlesh Rajesh Yadav•5,060

  @Kamlesh0007Posted over 1 year ago

  Congratulations on completing the challenge! That's a great achievement, and I'm sure you put a lot of effort into it. I really liked the way you approached the challenge and the code you wrote. You demonstrated a good understanding of the concepts and applied them effectively to solve the problem.I have a few suggestions to improve your code further. You need to remove and some styles to make it mobile responsive

  remove this styles
  @media only screen and (max-width: 39.7em)
  {
  body {
  margin: 1rem 0; 
  }
  .card__result, .card__summary {
  width: 100%;
  /* width: 300px; */ remove this
  height: 100%;
  display: flex;
  flex-direction: column;
  place-items: center;
  /* place-content: center; */
  /* justify-content: space-evenly; */
  gap: 1.3rem;
  padding: 2rem;
  border-radius: 0px 0px 32px 32px;
  }
  }
  .card {
  width: 100%;
  height: 100%;
  display: flex;
  flex-direction: row;
  place-items: center;
  place-content: center;
  box-shadow: 6px 7px 15px 1px hsla(0, 0%, 0%, 0.3);
  /* border-radius: 1.5rem; */ remove this only
  }
  

  0