Html,Sass,Javascript

Community feedback

• 

  P

  Rahexx•900

  @RahexxPosted 3 months ago

  Great job! Here’s some feedback from me:

  HTML

  1. It looks like you're missing a rating block, where the classes for your elements are referenced.
  2. You're using an ID, but in this case, it would be better to use a class.
  3. The alt attribute is missing for the icon-star.svg image.

  SASS

  1. Your styles look good overall.
  2. The submit button has a different background than the design specifies.

  JS

  1. Your JavaScript is great and clean.
  2. Good call on extracting the logic for removing the active class from the buttons into a separate function.

  Marked as helpful

  0

  ---

  

  lordag•240

  @lordagPosted 3 months ago

  @Rahexx About the alt attribute, I thought that by putting role="img" and aria-label="Star Icon" on the container and aria-hidden="true" on the image, I would not have to put text in the alt of the image because assistive technologies would treat the container as an image.

  I still need to get used to WAI-ARIA.

  For the button, I wanted to keep it disabled until the user selects a rating and decided to put a different background.

  Thanks again for your feedback, it's always helpful!

  1
• 

  hkaur108•310

  @hkaur108Posted 2 months ago

  Good Job!

  0