Skip to content
Submitted over 3 years ago

html(div) -css(grid-top-margin-etc)

Andrea Rigchac•10
@AndreaRigchac
Preview site (opens in new tab)View code (opens in new tab)
This is a solution for...Profile card component
  • HTML
  • CSS
1newbie

Design comparison

SolutionDesign

Solution retrospective

I'm new in the world of programming, I began with this challengue and my doubt is because in the moment i put in my variable "bodi" grid-template-columns: repeat(5, 1fr) and obviously specically in my variable "grid " grid-column: 3/5, well its was positioned correctly but I defined in other variable "body2" grid-column: 1/5; all was a disaster, becuase mine grid didn't function as i wanted. Finally i did this exercise and is similar but I think I was wrong a lot. I accept scolding but i know your advice will help me improve. PD: Sorry for my writing I speak spanish and i know that my english is a bit disastrous.

Community feedback

  • Ritesh_Gupta•520
    @b4n1y4Posted over 3 years ago

    Hey Andrea, this is not bad for a beginner..... Though there are a few things that could be improved.... I see that you have used a lot of divs...... it really helps in code review if you just documented as to what is the purpose of that div.... Try using semantic HTML... No one should expect a beginner to be perfect... You should check out others' markup and styling for knowledge... Here's mine - https://github.com/b4n1y4/profile-card-component-main

    Keep coding ✌

    0

Please log in to post a comment

Log in with GitHub

Join our Discord community

Join thousands of Frontend Mentor community members taking the challenges, sharing resources, helping each other, and chatting about all things front-end!

Join our Discord