HTML/CSS/SCSS BEM

Community feedback

• 

  Dharmik_487•1,740

  @Dharmik48Posted about 3 years ago

  Hey👋,

  I found a few issues with the site:

  • Try to use relative units like em and rem more rather than of px.

  Apart from these your solution is really nice, keep it up👍

  0
• 

  Ali Sbane•470

  @0x41-liPosted about 3 years ago

  Good work. Here are some points:

  • I assume that you did begin the project by working on the desktop and then mobile, I would suggest using a mobile-first design (begin with the mobile design first) in the next project, it's easier.
  • Also I check the project on my computer and phone, but it's too large, meaning that the card goes off the screen horizontally. On the desktop too, I assume that you have large screens, but you need to fix that, even with the scrollbars I can't scroll to the top of the card, I suggest that you add margin-top and margin-bottom at least to make the page scrollbar, in the screen that can't fit the card size.
  • For the alt attribute in the images that are just for the design and don't have any semantic meaning or are related to the content. Leave the alt attribute empty. Also note that when specifying alt attribute's value don't use keywords like image, graphic, Picture, as it's already an image, no need.

  Besides those points, keep up the good work.

  0